Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add further step to avoid message summary from breaking #3923

Closed

Conversation

Wladastic
Copy link
Contributor

@Wladastic Wladastic commented May 6, 2023

Background

It is already known that message summary could break or overwrite the message history,
I encountered a few problems which these two changes fix.

  • making sure that the new_messages are a deep copy as it turned out to break on my runs (less often, but happened)
  • adding extra escaping to make sure json conversion will not break.

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 12, 2023 5:13pm

@github-actions github-actions bot added the size/m label May 6, 2023
@github-actions github-actions bot added size/s and removed size/m labels May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.09 ⚠️

Comparison is base (2513178) 60.99% compared to head (29a4336) 60.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3923      +/-   ##
==========================================
- Coverage   60.99%   60.91%   -0.09%     
==========================================
  Files          73       73              
  Lines        3310     3316       +6     
  Branches      542      542              
==========================================
+ Hits         2019     2020       +1     
- Misses       1152     1157       +5     
  Partials      139      139              
Impacted Files Coverage Δ
autogpt/memory_management/summary_memory.py 54.54% <12.50%> (-5.99%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview May 11, 2023 21:40 Inactive
@anonhostpi anonhostpi mentioned this pull request May 12, 2023
5 tasks
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label May 12, 2023
@k-boikov
Copy link
Contributor

Isnt that obsolete now?

@Wladastic Wladastic closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts size/m
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants