-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report remaining budget to user #3313
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3313 +/- ##
==========================================
- Coverage 61.31% 61.03% -0.29%
==========================================
Files 72 72
Lines 3304 3313 +9
Branches 542 543 +1
==========================================
- Hits 2026 2022 -4
- Misses 1141 1152 +11
- Partials 137 139 +2
☔ View full report in Codecov by Sentry. |
FYI @Vwing |
Tests fail @rob-luke |
The tests started failing when you merged main. But I have fixed the issues. So this should be good for review @Pwuts @collijk @BillSchumacher |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it out, and it looks great! Thank you for taking this on, @rob-luke.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I forgot to press "viewed" 😅
Thanks @Vwing and @merwanehamadi |
The failing test is unrelated to this change. I do not have access to restart the CI. When there is a push to main I will merge it in and that will restart the CI. |
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
Thanks for the info @p-i- |
I agree. This is a rather simple change but such a useful one. And while it's not as extensive as #3466, it solves the problem for most people for now. It may need to be revisited soonish to come up with a more generic implementation - but for now it's definitely candidate material to be considered for a review despite the ongoing re-arch effort. Also, it's worth keeping in mind that this change is perfectly in line with all project recommendations to monitor API usage. So, definitely do consider this for integration now: https://github.com/Significant-Gravitas/Auto-GPT#readme
|
it seems, there's a dedicated budget manager implementation in progress: #3919 |
Would not close it yet. Your patch looks straightforward and should work for many folks "as is" while the other stuff still is in the pipeline and might take a couple of weeks before it really arrives in the form of a functional feature |
Background
Closes #6
Following #762, this PR reports the remaining and total budget to the user.
Changes
Reports the budget to the user if the budget is set.
The budget is report before "NEXT ACTIONS"
Documentation
Modified
print_assistant_thoughts
to report the remaining budget and the total budget.Test Plan
Wrote tests. But you can also see the change in the figure below
Questions to reviewers
python -m autogpt --report_budget
?PR Quality Checklist