-
Notifications
You must be signed in to change notification settings - Fork 44.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver customization options #2066
Driver customization options #2066
Conversation
@thehunmonkgroup There are conflicts now |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
1 similar comment
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
2 similar comments
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Hello - First comment on GitHub! I've installed Python 3.10 on Linux / Ubuntu with the latest stable release of Auto-GPT. It is working good except for the browse_website command, which is currently throwing the following error:
It sounds like this branch might resolve the issue, but I figured I'd add my two cents just in case it's helpful! |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Can we get this in? It's a simple patch that I've had to fix conflicts on several times, would really like to close this sucker out. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
@thehunmonkgroup Please, fix conflict. Squash (to a single commit) and rebase to master. |
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Done. I really hope you guys get this in now, this is the fourth time I've fixed merge conflicts, probably not gonna do any more of that. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
At this point, I have to be approaching the most times anyone has resolved a conflict on a PR for this project, right?? |
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
Note this looks like a useful change to be reviewed/integrated despite the ongoing re-arch effort, it's primarily config-level, with very few code changes (and those primarily are about adding selenium options for people on older systems). So definitely do consider for review/integration to help close some PRs. Thanks |
I don't agree with merging right now. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Is it worth it to keep updating this PR? Could it still be under consideration? Are y'all done with the big refactor? |
Background
Basically, the way the selenium drivers are set up doesn't allow flexibility for older installs (I'm on Debian 10 headless), or customizing the driver options to work around issues (like my requirement for the
--no-sandbox
option).Changes
This adds two new configuration variables:
DRIVER_EXECUTABLE_PATH
: Allows specifying a custom driver binary.DRIVER_EXTRA_OPTIONS
: Allows passing other needed options to the driver.Documentation
They are clearly documented with comments in
.env.template
Test Plan
The changes are quite simple, I didn't do any testing beyond making sure the features work as intended, and that no errors happen when the new configuration options are not used.
PR Quality Checklist