Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@opentelemetry/exporter-otlp-grpc is deprecated #1212

Closed
Zoharos opened this issue May 29, 2022 · 10 comments
Closed

@opentelemetry/exporter-otlp-grpc is deprecated #1212

Zoharos opened this issue May 29, 2022 · 10 comments
Labels
documentation Improvements or additions to documentation

Comments

@Zoharos
Copy link

Zoharos commented May 29, 2022

Hi,
I noticed that in the documentation it is recommend to use @opentelemetry/exporter-otlp-grpc although it is deprecated.

Maybe update the documentation @opentelemetry/exporter-trace-otlp-grpc and @opentelemetry/exporter-metrics-otlp-grpc and that it is supported.

Thanks

@welcome
Copy link

welcome bot commented May 29, 2022

Thanks for opening this issue. A team member should give feedback soon. In the meantime, feel free to check out the contributing guidelines.

@srikanthccv
Copy link
Member

@Zoharos feel free to send a pull request updating the docs if you are interested. Otherwise, one of us will review the post content again and update all the relevant deps.

@pranay01
Copy link
Collaborator

@Zoharos here's the repo for the website - https://github.com/SigNoz/signoz.io/

@pranay01 pranay01 added the documentation Improvements or additions to documentation label May 29, 2022
@Zoharos
Copy link
Author

Zoharos commented May 31, 2022

Hi,
Before I leave a PR I checked if the new recommended libraries are supported by signoz and it made me some problems.
In http I get 400 bad request because of unknownfield scopeSpans ERROR.
In grpc I get http2Server.HandleStreams received bogus greeting from client ERROR.

@srikanthccv
Copy link
Member

@Zoharos thanks for taking a stab at it. There was a change in proto since 0.15.0 because of renaming InstrumentationLibrarySpans to ScopeSpans https://github.com/open-telemetry/opentelemetry-proto/releases/tag/v0.15.0. Which version of @opentelemetry/exporter-trace-otlp-* are you using?

@Zoharos
Copy link
Author

Zoharos commented Jun 1, 2022

@srikanthccv with both grpc and http packages I tried with the latest version as of now (0.29.0)

@HyunGook-Kim
Copy link

@opentelemetry/exporter-trace-otlp-http with version 0.28.0 works fine. But 0.29.0 above requires collector version 0.48 and up(https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines).

So, i tried to upgrade my signoz/otelcontribcol version from 0.45.1-1.0 to 0.5.0 and the docker image throws an error cannot unmarshal the configuration: unknown exporters type "clickhousetraces" for "clickhousetraces" (valid values: [sapm sentry awsemf kafka azuremonitor datadog file influxdb jaeger_thrift logzio alibabacloud_logservice awsprometheusremotewrite stackdriver awsxray loadbalancing sumologic awskinesis jaeger opencensus otlphttp splunk_hec tanzuobservability zipkin clickhousemetricswrite newrelic loki prometheusremotewrite elasticsearch googlecloud otlp prometheus signalfx tencentcloud_logservice carbon humio elastic f5cloud honeycomb logging parquet skywalking clickhouse dynatrace]

After i changed the clickhousetraces to clickhouse in otel-collector-config.yml, it cause error on migration.

It seems signoz/release/v0.9.1 branch still use signoz/otelcontribcol:0.45.1-1.0. Is there a plan for upgrade version of otelcontribcol in the future?

@srikanthccv
Copy link
Member

We will probably upgrade in next major release

@ankitnayan
Copy link
Collaborator

@srikanthccv
Copy link
Member

With our distribution signoz-otel-collector, this is not an issue anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

5 participants