Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeleeArmor/PierceArmor differs from Base Melee/Pierce #89

Open
denniske opened this issue Mar 18, 2021 · 2 comments
Open

MeleeArmor/PierceArmor differs from Base Melee/Pierce #89

denniske opened this issue Mar 18, 2021 · 2 comments

Comments

@denniske
Copy link

I have found that for some siege units the MeleeArmor/PierceArmor differs from Base Melee/Pierce in the Armours dict.

e.g. Battering Ram
https://github.com/SiegeEngineers/aoe2techtree/blob/master/data/data.json#L13305

"MeleeArmor": 0,
...,
"PierceArmor": 180,

vs.

"Armours": [
  {
      "Amount": -3,
      "Class": 4
  },
  {
      "Amount": 180,
      "Class": 3
  },
  ...
],

Other siege units affected:

Capped Ram
https://github.com/SiegeEngineers/aoe2techtree/blob/master/data/data.json#L6269
Siege Ram
https://github.com/SiegeEngineers/aoe2techtree/blob/master/data/data.json#L7536
Siege Tower
https://github.com/SiegeEngineers/aoe2techtree/blob/master/data/data.json#L11638

@HSZemi
Copy link
Member

HSZemi commented Mar 21, 2021

Those properties are actually named "Displayed[Property]" in the game files.
I guess they only influence what is being displayed in-game, but not what is actually calculated. https://github.com/SiegeEngineers/aoe2techtree/blob/master/scripts/generateDataFiles.py#L569

@LOSER4ever
Copy link
Contributor

This issue can be closed because devs have fixed it themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants