Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draco compression support #27

Closed
Siccity opened this issue Sep 25, 2019 · 14 comments
Closed

Add draco compression support #27

Siccity opened this issue Sep 25, 2019 · 14 comments
Labels
enhancement New feature or request

Comments

@Siccity
Copy link
Owner

Siccity commented Sep 25, 2019

glb.zip

Originally requested by @umresh in #26 (comment)

@Siccity Siccity added the enhancement New feature or request label Sep 25, 2019
@umresh
Copy link

umresh commented Sep 25, 2019

Hi, When can you add the draco support. Thanks

@Siccity
Copy link
Owner Author

Siccity commented Sep 25, 2019

I don't know. Perhaps after I'm done with async import

@umresh
Copy link

umresh commented Oct 22, 2019

Hi, any update on draco support.

@Siccity
Copy link
Owner Author

Siccity commented Oct 23, 2019

Currently in progress. I haven't had much time to work on it since I just moved.
I was trying to find a way to make plug-ins optional but it's very hard, so I might just end up hardcoding Draco support into GLTFUtility. But a problem with Google's Draco plug in is that it requires your project to allow unsafe code. I am not a fan of putting such requirements on my users.

@naveenan-alt
Copy link

naveenan-alt commented Nov 26, 2019

Have you added support for draco compression? Some of my models that I get from client are draco compressed and they want to load it.

@mschneider
Copy link

You could precompile the DLL containing the unsafe code, this would allow you to use it without requiring the user to compile their own unsafe code.

@mschneider
Copy link

Using an assembly definition file it should also be possible to configure the unsafe flag only for a certain namespace / compilation unit. Have a look here: https://docs.unity3d.com/Manual/ScriptCompilationAssemblyDefinitionFiles.html

@Siccity
Copy link
Owner Author

Siccity commented Jan 8, 2020

Good call @mschneider
Marking allow unsafe on the assembly definition sounds like a great solution

@umresh
Copy link

umresh commented Mar 9, 2020

Hey any update? Or could you point me in right direction how to do it?

@IsmaeelGoraya
Copy link

Any update on this?

@Siccity
Copy link
Owner Author

Siccity commented Jun 13, 2020

Unfortunately not yet, no

@leon
Copy link
Contributor

leon commented Sep 17, 2020

We really need the draco support for our AR app.

@Siccity Would it be possible to pay you to fix it?

@Siccity
Copy link
Owner Author

Siccity commented Sep 17, 2020

@leon
Yes It'd be possible. Send me an email with your deadline and I'll see if I got the time for it.

@Siccity
Copy link
Owner Author

Siccity commented Sep 29, 2020

Draco is now finally supported! 08ec501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants