Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shelly 1pm Mini Gen 3 #228

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

cemilbrowne
Copy link
Contributor

Added support for Shelly 1pm Mini Gen 3

Blueprint Checklist

  • You viewed the README and conformed to the naming conventions
  • You ordered the actions as stated in the README action order
  • All filenames are lowercase and uses '-' for spaces and not '_' while using {service-name}-{switch-name-or-type}.yaml format
  • Images are png
  • Image backgrounds are transparent and is cropped to the device boundries
  • Images has a maximum width of 800px and maximum height of 500px
  • There are no missing buttons or actions
  • Your integration/service is running on the latest version
  • You have tested your blueprints and made sure each button and action works

@Sian-Lee-SA
Copy link
Owner

Same deal as to my response to your other PR

@cemilbrowne
Copy link
Contributor Author

OK; I tweaked the two settings here. On the Moes one, it was already tap and I reused image - I think that one is good to go potentially?

@Sian-Lee-SA
Copy link
Owner

I completely understand and sorry for the sudden late change, I literally renamed all the blueprints from tap to press after presenting it to you to do the same. Everything looks fine, Cheers. In regards to the image, I generally get authors to tighten their images and avoid any padding but I probably let that one slide because it's pretty close and I was just in a "whatever" mood but in that regards as it is a copy, i can't expect you to change it and look different to the original so it's fine.

@Sian-Lee-SA Sian-Lee-SA changed the title Support for Shelly 1pm Mini Gen 3 Added Shelly 1pm Mini Gen 3 Jun 7, 2024
@Sian-Lee-SA Sian-Lee-SA merged commit f0b615a into Sian-Lee-SA:master Jun 7, 2024
@cemilbrowne
Copy link
Contributor Author

Thanks for creating this add-on, glad I could contribute!

@cemilbrowne cemilbrowne deleted the shelly1pmgen3 branch July 2, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants