Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ZHA & Z2M SNZB-01P #215

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Conversation

harvindhillon
Copy link
Contributor

@harvindhillon harvindhillon commented Feb 26, 2024

Blueprint Checklist

  • You viewed the README and conformed to the naming conventions
  • You ordered the actions as stated in the README action order
  • All filenames are lowercase and uses '-' for spaces and not '_' while using {service-name}-{switch-name-or-type}.yaml format
  • Images are png
  • Image backgrounds are transparent and is cropped to the device boundries
  • Images has a maximum width of 800px and maximum height of 500px
  • There are no missing buttons or actions
  • Your integration/service is running on the latest version
  • You have tested your blueprints and made sure each button and action works

Zigbee2MQTT

  • (older devices) You have ensured legacy is off/false for the device in the Z2M devices Settings (specific) page and that your actions matches those with legacy off?

@Sian-Lee-SA
Copy link
Owner

please crop images to device boundries

@harvindhillon
Copy link
Contributor Author

Cropped Images for ZHA and Z2M

@Sian-Lee-SA
Copy link
Owner

Please remove zigbee2mqtt-tuya-4-button-scene.yaml from the PR as I'm the author and using the device daily with the order they are in. The comment about the irregular order was pointing out that either Z2M screwed it up or the FW. I will investigate this when I update Z2M and see if they have fixed it and adjust accordingly.

@Sian-Lee-SA Sian-Lee-SA changed the title Added support for SNZB-01P and fixed TuYa 4 Button Scene (TS0044) button order Added ZHA & Z2M SNZB-01P Mar 7, 2024
@Sian-Lee-SA
Copy link
Owner

Cheers 🍷

@Sian-Lee-SA Sian-Lee-SA merged commit c81035e into Sian-Lee-SA:master Mar 7, 2024
@harvindhillon
Copy link
Contributor Author

No problem, I wasnt sure if I did it correctly, been a long long time since I was a full time dev using git :)
Had to rediscover some of the commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants