Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ZHA IKEA Rodret wireless dimmer #204

Merged
merged 4 commits into from
Jan 7, 2024

Conversation

nwithan8
Copy link
Contributor

@nwithan8 nwithan8 commented Jan 1, 2024

Blueprint Checklist

  • You viewed the README and conformed to the naming conventions
  • You ordered the actions as stated in the README action order
  • All filenames are lowercase and uses '-' for spaces and not '_' while using {service-name}-{switch-name-or-type}.yaml format
  • Images are png
  • Image backgrounds are transparent and is cropped to the device boundries
  • Images has a maximum width of 800px and maximum height of 500px
  • There are no missing buttons or actions
  • Your integration/service is running on the latest version
  • You have tested your blueprints and made sure each button and action works

Zigbee2MQTT

  • (older devices) You have ensured legacy is off/false for the device in the Z2M devices Settings (specific) page and that your actions matches those with legacy off?

Switch does have a "hold (released)" for top and bottom button, but both trigger the same ZHA event, so cannot be reliably mapped.

@Sian-Lee-SA
Copy link
Owner

Image needs to be cropped properly

@nwithan8
Copy link
Contributor Author

nwithan8 commented Jan 6, 2024

Image needs to be cropped properly

It has been cropped properly. That nub at the top is part of the product: https://www.ikea.com/us/en/p/rodret-wireless-dimmer-power-switch-smart-white-80559800/

@Sian-Lee-SA
Copy link
Owner

Not sure what the nub at top has to do with cropping properly, as stated in the "rules" for a PR, it needs to be cropped to the device edges. The x/sides are no where near the device and the top and bottom still has padding from the device

@Sian-Lee-SA
Copy link
Owner

There is also a nice image and blueprint for this device in the repo using Zigbee2MQTT (zigbee2mqtt-ikea-e2201). I would suggest ussing those resources and convert for ZHA

@Sian-Lee-SA Sian-Lee-SA changed the title [ZHA] Add IKEA Rodret wireless dimmer Added ZHA IKEA Rodret wireless dimmer Jan 7, 2024
@Sian-Lee-SA Sian-Lee-SA merged commit 43acc8c into Sian-Lee-SA:master Jan 7, 2024
2 checks passed
@Sian-Lee-SA
Copy link
Owner

Cheers

@nwithan8 nwithan8 deleted the ikea-rodret-zha branch March 13, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants