Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native 0.16.0: 'RCTSparseArray.h' file not found #26

Open
ivanbrens opened this issue Dec 5, 2015 · 11 comments
Open

React-Native 0.16.0: 'RCTSparseArray.h' file not found #26

ivanbrens opened this issue Dec 5, 2015 · 11 comments

Comments

@ivanbrens
Copy link

According to some highlights of the release here:
http://www.reactnative.com/react-native-v0-16-0-rc-and-v0-15-0-released/

RCTSparseArray was replaced by NSDictionary.

Will you upgrade?

@plrthink
Copy link

plrthink commented Dec 7, 2015

+1

@rreusser
Copy link

rreusser commented Dec 9, 2015

@DickyT — I'm looking into fixing this issue. Your repo doesn't have an issues page, but the plan is to submit a PR to your repo. Sound good?

@DickyT
Copy link

DickyT commented Dec 10, 2015

@rreusser that will be great, thx!

@alvinwoon
Copy link

Thanks! @rreusser @DickyT

@rreusser
Copy link

I got sidetracked because we ran into like fifty problems when we upgraded to RN 0.16 and ended up downgrading until some things are straightened out, but I'll test this out today.

For anyone wondering, it appears it really might just be as simple as running s/RCTSparseArray/NSDictionary/g on the file. It appears it's just a change in argument type with no change in behavior, correct?

See: https://github.com/Shuangzuan/RCTRefreshControl/blob/master/RCTRefreshControl.m#L27-L29

@DickyT
Copy link

DickyT commented Dec 12, 2015

@rreusser I think you are correct.

PS. I just answered the wrong stuff and I deleted one response, never mind if you guys see an email

@richarddewit
Copy link

@rreusser - Your repo works! 👍
But the npm version is outdated, so could you push the new version online?

Thanks! You too @DickyT

@samuelkraft
Copy link

UIRefreshControl have been added to core since 0.16.0. facebook/react-native#4205

@richarddewit
Copy link

@samuelkraft - Cool, but I like the refresh-thingy from this module better though

@bakso
Copy link

bakso commented Dec 31, 2015

replace

RCTSparseArray *viewRegistry

with

NSDictionary<NSNumber *, UIView *> *viewRegistry 

@Obooman
Copy link

Obooman commented May 31, 2016

Just use my fork version here.It seems that this repo is not under mantainess any more.The fork version will keep update to latest react-native version.
@richarddewit @ivanbrens @plrthink
and you can use

$ npm install react-native-drop-refresh

to install that npm package.It's now compatible with react-native 0.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants