Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic when trying to update to invalid version. #604

Closed
tanema opened this issue Jan 2, 2019 · 0 comments · Fixed by #611
Closed

Panic when trying to update to invalid version. #604

tanema opened this issue Jan 2, 2019 · 0 comments · Fixed by #611
Assignees
@batasrki

Comments

@tanema
Copy link
Contributor

tanema commented Jan 2, 2019

Describe the bug
Themekit will panic instead of providing a helpful error message if an invalid version is provided to the update command.

To Reproduce
Steps to reproduce the behavior:

  1. run command theme update --version=v.0.8.2

Expected behavior
Themekit should provide an error that tells the user that the version provided is invalid.

Additional context
First experienced here: #544 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@batasrki batasrki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added a check for a valid version before all version uses Shopify/themekit
2 participants
@batasrki @tanema