Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Kaminari is one of the most popular gems in the Rails ecosystem.
Kaminari's
.page
scope is defined dynamically and not detected by Tapioca's scopes compiler. Also,.page
uses.extending
to extend the relation with more methods (e.g..per
,.total_count
,.total_pages
,.current_page
).See issue #1859 for more details.
Implementation
This PR adds a compiler for Kaminari that adds the
.page
method toGeneratedRelationMethods
. The return type is a union:If the
ActiveRecordRelations
compiler is not enabled, this compiler will take that into account.Tests
Tests are included.