Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support ActiveRecord::Store? #1217

Open
sambostock opened this issue Oct 6, 2022 · 2 comments
Open

Should we support ActiveRecord::Store? #1217

sambostock opened this issue Oct 6, 2022 · 2 comments
Labels
enhancement New feature or request feature help-wanted Extra attention is needed

Comments

@sambostock
Copy link
Contributor

Our application uses ActiveRecord::Store, but Tapioca does not support it, so we had to write a shim. I began investigating adding it, but while looking for where to implement it I discovered we support ActiveRecord::TypedStore.

Before I go any further, I'd like to establish the project's stance:

  • Are we open to supporting ActiveRecord::Store, or
  • do we recommend consumers use ActiveRecord::TypedStore instead?

I should note that I only found out about TypedStore because I looked into adding support for Store. If we prefer one over the other, we could, for example, log a message if we detect the host app uses ActiveRecord::Store advising they switch.

@sambostock sambostock added enhancement New feature or request question Further information is requested labels Oct 6, 2022
@rafaelfranca
Copy link
Member

Using ActiveRecord::Store is fine, so we should support it.

@rafaelfranca rafaelfranca added help-wanted Extra attention is needed feature and removed question Further information is requested labels Oct 11, 2022
@dom-binti
Copy link
Contributor

As far as I can tell, the TypedStore compiler doesn't support things like prefix and suffix, presumably because those aren't persisted anywhere on the object. ActiveRecord::Store has the same limitation -- is it ok to add an ActiveRecord::Store compiler that only support basic usage without prefix/suffix/etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants