Updates for rubocop deprecations #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donk-shopify
force-pushed
the
donk/checks/rubocop_1
branch
from
108e147 to
96b0f8e
Compare
Rubocop deprecates the use of Cop as a base class (https://docs.rubocop.org/rubocop/v1_upgrade_notes.html). This leads to warnings in projects that use the smart_todo gem.
Replacing the deprecated Cop base class with Cop::Base means that we need to avoid investigate. Following the example of comment processing Cops including with rubocop, we should instead use on_new_investigation. The expect_offense test helper also needed reworking. Cop::Base doesn't allow access to the offenses detected. Those should come from the InvestigationReport from the Commissioner instance that invokes the investigation (via Commissioner::investigate).
donk-shopify
force-pushed
the
donk/checks/rubocop_1
branch
from
96b0f8e to
3c3f962
Compare
Morriar
approved these changes
Oct 30, 2024
Oh, so do I normally. I was getting lazy. I'll fix that before merging. |
donk-shopify
force-pushed
the
donk/checks/rubocop_1
branch
from
3c3f962 to
45186bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.rubocop.org/rubocop/v1_upgrade_notes.html
This is causing warnings in rubocop runs in repositories that use this gem.