Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include workspace name as part of telemetry #2883

Merged

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Nov 19, 2024

Motivation

I made a mistake when adding the workspace as part of the telemetry. I thought it was the workspace name, but it's actually the path to the workspace, which may include things like /Users/name/....

Let's return only the workspace name to fully anonymize the telemetry.

@vinistock vinistock added vscode This pull request should be included in the VS Code extension's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels Nov 19, 2024 — with Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock marked this pull request as ready for review November 19, 2024 19:31
@vinistock vinistock requested a review from a team as a code owner November 19, 2024 19:31
@vinistock vinistock merged commit 3f62b8e into main Nov 20, 2024
38 checks passed
@vinistock vinistock deleted the 11-19-only_include_workspace_name_as_part_of_telemetry branch November 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Changes that aren't bugfixes, enhancements or breaking changes vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants