Merge composed bundle environment into Ruby object #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
the
vscode
Graphite App
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
11-07-start_returning_composed_bundle_environment_from_initialize_request
branch
from
be91265 to
feaab3e
Compare
vinistock
force-pushed
the
11-07-merge_composed_bundle_environment_into_ruby_object
branch
from
0915b82 to
25f00de
Compare
andyw8
reviewed
Nov 20, 2024
andyw8
approved these changes
Nov 20, 2024
vinistock
changed the base branch from
11-07-start_returning_composed_bundle_environment_from_initialize_request
to
graphite-base/2881
vinistock
force-pushed
the
graphite-base/2881
branch
from
feaab3e to
a738d5b
Compare
vinistock
force-pushed
the
11-07-merge_composed_bundle_environment_into_ruby_object
branch
from
25f00de to
2b3512d
Compare
Merge activity
|
vinistock
deleted the
11-07-merge_composed_bundle_environment_into_ruby_object
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1767, closes #1785
Merge the composed bundle environment into the workspace's Ruby object. The language server sets up the composed bundle environment, returns it, and then we merge that into the Ruby object to ensure that any other parts of the extension are using the exact same environment.
This fixes a few issues people have been experiencing with the debug client.
Implementation
Started merging the composed environment into the Ruby object and then started relying on that for the debug client.
Automated Tests
Added some tests. I will follow up with another PR that creates an integration test for a scenario that currently fails.