Eagerly compute SHA's for watched files #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
vscode
Graphite App
vinistock
force-pushed
the
11-07-eagerly_compute_sha_s_for_watched_files
branch
from
f3f9236 to
ca3945b
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
vinistock
commented
Nov 16, 2024
vinistock
force-pushed
the
11-07-eagerly_compute_sha_s_for_watched_files
branch
from
ca3945b to
130f3fe
Compare
vinistock
force-pushed
the
11-07-eagerly_compute_sha_s_for_watched_files
branch
from
130f3fe to
bc9322f
Compare
vinistock
commented
Nov 16, 2024
vinistock
commented
Nov 16, 2024
andyw8
reviewed
Nov 19, 2024
andyw8
reviewed
Nov 19, 2024
andyw8
reviewed
Nov 19, 2024
andyw8
approved these changes
Nov 19, 2024
vinistock
force-pushed
the
11-07-eagerly_compute_sha_s_for_watched_files
branch
from
bc9322f to
c5de676
Compare
vinistock
force-pushed
the
11-07-eagerly_compute_sha_s_for_watched_files
branch
from
c5de676 to
cd57b1d
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes two issues related to automated restarts. The first one is preventing undesired restarts immediately after the server finishes booting.
The second one is preventing unwanted restarts if a create event is fired for an existing file. In theory, this shouldn't happen, but our tests tell a different story and we consistently see a create event getting fired for updates.
Implementation
The two fixes are:
didCreateas well. If the file being updated fires a create event and the content SHA matchesAutomated Tests
Added a new test and reduced some of the sleeps on the other test, which is taking a bit too long.