Extract progress notifications to helpers #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @vinistock and the rest of your teammates on |
vinistock
added
server
Graphite App
andyw8
approved these changes
Nov 1, 2024
vinistock
changed the base branch from
11-01-move_supports_progress_to_global_state
to
graphite-base/2816
vinistock
force-pushed
the
11-01-extract_progress_notifications_to_helpers
branch
from
e22610d to
9c5e4e4
Compare
vinistock
force-pushed
the
graphite-base/2816
branch
from
014f81c to
93f9669
Compare
vinistock
force-pushed
the
11-01-extract_progress_notifications_to_helpers
branch
from
9c5e4e4 to
b09425f
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR extracts progress related notifications to helpers, to make it easier for add-ons (and the LSP itself) use progress more often.
Implementation
Essentially just make some factory methods like we do for other notifications.
Automated Tests
Existing tests cover it.