Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launch mode integration tests #2766

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

vinistock
Copy link
Member

Motivation

This PR adds launch mode integration tests and fixes two small issues.

Implementation

With launch mode, users can run the Ruby LSP with missing dependencies, so we need to account for that when fetching locked gems from Bundler, which are both fixes included.

Automated Tests

Added integration tests verifying 3 common scenarios.

@vinistock vinistock added server This pull request should be included in the server gem's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels Oct 23, 2024
@vinistock vinistock requested a review from a team as a code owner October 23, 2024 19:46
@vinistock vinistock force-pushed the vs-add-launch-integrations branch from 7e99421 to e50b9ab Compare October 23, 2024 19:51
project-words Outdated Show resolved Hide resolved
Base automatically changed from vs-add-launcher-mode to main October 23, 2024 20:05
@vinistock vinistock force-pushed the vs-add-launch-integrations branch 4 times, most recently from 9120a56 to 324a642 Compare October 24, 2024 15:28
lib/ruby_lsp/server.rb Show resolved Hide resolved
test/integration_test.rb Outdated Show resolved Hide resolved
test/integration_test.rb Outdated Show resolved Hide resolved
test/integration_test.rb Show resolved Hide resolved
@vinistock vinistock force-pushed the vs-add-launch-integrations branch 3 times, most recently from bfdc4cb to cfb68a1 Compare October 24, 2024 17:19
@vinistock vinistock self-assigned this Oct 24, 2024
@vinistock vinistock force-pushed the vs-add-launch-integrations branch from cfb68a1 to f8ae0b0 Compare October 24, 2024 17:48
@vinistock vinistock merged commit 664b8cc into main Oct 24, 2024
35 checks passed
@vinistock vinistock deleted the vs-add-launch-integrations branch October 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants