Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion for global variables #2749

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

snutij
Copy link
Contributor

@snutij snutij commented Oct 21, 2024

Motivation

Iteration of #2644

Handle global variables in completion requests.

Implementation

  • Add $ as a new trigger_character (see this comment)
  • Add listener for all global variable nodes
  • Find in index with prefix
  • Push entries as CompletionItem in response_builder

Automated Tests

  • Added a test with assertions for each kind of global variable, and RBS completions.

Manual Tests

  • Write $ within a file, you should see completions coming from the RBS declaration.
  • Write $foo = 1, then bellow $f, you should see the completion.
Kapture.2024-10-21.at.23.31.16.mp4

@snutij snutij requested a review from a team as a code owner October 21, 2024 21:37
@vinistock vinistock added enhancement New feature or request server This pull request should be included in the server gem's release notes labels Oct 22, 2024
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@vinistock vinistock merged commit 046d53a into Shopify:main Oct 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants