Add completion for global variables #2749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Iteration of #2644
Handle global variables in completion requests.
Implementation
$
as a newtrigger_character
(see this comment)CompletionItem
inresponse_builder
Automated Tests
Manual Tests
$
within a file, you should see completions coming from the RBS declaration.$foo = 1
, then bellow$f
, you should see the completion.Kapture.2024-10-21.at.23.31.16.mp4