Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bridgeless support on iOS #2223

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Fix bridgeless support on iOS #2223

merged 3 commits into from
Feb 19, 2024

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Feb 16, 2024

Why

solving crash when running with react-native new architecture mode with bridgeless mode

How

in bridgeless mode, react-native does not support fallback for jsCallInvoker and the bridge.jsCallInvoker is nil. the app will crash when accessing null pointer. the pr tries to get jsCallInvoker from turbo module setup in new architecture mode.

Test Plan

$ npx react-native@latest init RN074 --version nightly
$ yarn add @shopify/react-native-skia
$ cd ios
$ RCT_NEW_ARCH_ENABLED=1 pod install
# running app in xcode

@Kudo
Copy link
Contributor Author

Kudo commented Feb 19, 2024

thanks for fixing the syntax. for the pod install error, it looks like related to facebook/react-native#42698 and unrelated to this pr's changes.

@wcandillon wcandillon self-requested a review February 19, 2024 06:25
@wcandillon
Copy link
Contributor

Thank You @Kudo 🙌🏼 We'll soon update the fabric example project to bridgeless mode so that this is tested on our side in the future.

@wcandillon wcandillon merged commit 547a861 into Shopify:main Feb 19, 2024
11 checks passed
@Kudo Kudo deleted the fix-bridgeless branch February 19, 2024 11:41
@Kudo
Copy link
Contributor Author

Kudo commented Feb 19, 2024

thanks @wcandillon! that's not hurry since bridgeless would be more stable from 0.74 (nightly now). especially that the cxxBridge.runtime would be available from 0.74. we are just helping some expo-go vendored modules works on bridgeless for sdk 51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants