-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing dispose and typename to skparagraph #2570
fix: add missing dispose and typename to skparagraph #2570
Conversation
Seems like react-native-skia/package/cpp/api/JsiSkHostObjects.h Lines 72 to 75 in 30c1284
|
The name of the class you are referring to is
|
I just noticed that |
can you run |
@wcandillon done |
🎉 This issue has been resolved in version 1.3.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Since there is no dispose method on
JsiSkHostObject
i had to add my own. Tested it on a project with huge paragraph usage - no crashes.