Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signatures for Sidekiq::Web #246

Closed
wants to merge 1 commit into from
Closed

Add signatures for Sidekiq::Web #246

wants to merge 1 commit into from

Conversation

yuichi-tanaka
Copy link

Type of Change

I added it to prevent check errors when using Sidekiq::Web.

  • Add RBI for a new gem
  • Modify RBI for an existing gem
  • Other:

Changes

  • Gem name: sidekiq
  • Gem version: sidekiq (7.1.5)

@yuichi-tanaka yuichi-tanaka requested a review from a team as a code owner May 17, 2024 04:39
@yuichi-tanaka
Copy link
Author

I have signed the CLA!

@andyw8
Copy link
Contributor

andyw8 commented May 17, 2024

@yuichi-tanaka if you add require "sidekiq/web" to sorbet/tapioca/require.rb and regenerate the RBIs a signature will be automatically added.

@Morriar
Copy link
Contributor

Morriar commented Nov 4, 2024

@yuichi-tanaka if you add require "sidekiq/web" to sorbet/tapioca/require.rb and regenerate the RBIs a signature will be automatically added.

Look like the right solution, closing this PR 👍

@Morriar Morriar closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morriar Morriar Awaiting requested review from Morriar Morriar is a code owner automatically assigned from Shopify/sorbet

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan KaanOzkan is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuichi-tanaka @andyw8 @Morriar