Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Improve typings on Observable types #1182

Closed
ismail-syed opened this issue Nov 15, 2019 · 1 comment
Closed

Improve typings on Observable types #1182

ismail-syed opened this issue Nov 15, 2019 · 1 comment
Labels
Effort: low Package: graphql-testing Package: jest-mock-apollo stale Stale issue that hasn't received any attention in a while

Comments

@ismail-syed
Copy link
Contributor

ismail-syed commented Nov 15, 2019

The quilt TypeScript upgrade in #962 required some explicit return types on Observables. I started work on improving the explicit return types but that needed further changes. It was best to leave it out of the already large PR and should be addressed in the future PR. - context

Related packages:

  • ./packages/jest-mock-apollo/dist/src/MockApolloLink.d.ts
  • ./packages/jest-mock-apollo/src/MockApolloLink.ts
  • ./packages/graphql-persisted/dist/src/tests/utilities.d.ts
  • ./packages/graphql-persisted/src/tests/utilities.ts
  • ./packages/graphql-testing/dist/src/links/mocks.d.ts
  • ./packages/graphql-testing/src/links/mocks.ts
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issue that hasn't received any attention in a while label Oct 4, 2020
@stale stale bot closed this as completed Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Effort: low Package: graphql-testing Package: jest-mock-apollo stale Stale issue that hasn't received any attention in a while
Projects
None yet
Development

No branches or pull requests

1 participant