Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Select documentation #224

Closed
mattchidley opened this issue Nov 17, 2017 · 1 comment
Closed

Typo in Select documentation #224

mattchidley opened this issue Nov 17, 2017 · 1 comment
Milestone

Comments

@mattchidley
Copy link

Issue summary

Description for onFocus: "Callback when checkbox is focussed"
link: https://polaris.shopify.com/components/forms/select#navigation

Expected behavior

I believe this should say "Callback when select is focussed"

@kaelig
Copy link
Contributor

kaelig commented Nov 17, 2017

Thank you for reporting this, @mattchidley! A fix will be published in the next version of Polaris :)

Update Dec 4, 2017: a fix was merged in our internal repository. The next public version of Polaris will feature the fix.

@dfmcphee dfmcphee added this to the v1.9.0 milestone Nov 21, 2017
@kaelig kaelig closed this as completed Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants