Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link on Embedded App page #10

Closed
chrispappas opened this issue Apr 21, 2017 · 1 comment
Closed

Broken link on Embedded App page #10

chrispappas opened this issue Apr 21, 2017 · 1 comment

Comments

@chrispappas
Copy link

Issue summary

The link within the smaller text blurb:

This component only works within embedded apps. Read the EASDK getting started guide for more details on how to use the EASDK with Polaris.

refers to the wrong location.

Expected behavior

The link should probably refer to the same link as the larger text above https://help.shopify.com/api/sdks/shopify-apps/embedded-app-sdk/getting-started

Actual behavior

Navigates you to https://github.com/Shopify/polaris/blob/master/documentation/Embedded%20apps.md

Steps to Reproduce the Problem

  1. Click the link
  2. Get to a 404 page on github

Specifications

  • Polaris version: N/A
  • React version: N/A
  • Browser: All
  • Device: All
  • Operating System: All

NOTE: This repo is only used for reporting issues and new feature requests. We are not accepting pull requests at this point in time.

@lemonmade
Copy link
Member

Thanks for the issue @chrispappas. We've added this to our internal issue tracker and this should be resolved in our next release. I'll close this issue when the fix is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants