-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change PUT
methods to POST
methods for better compat with API mode apps
#992
Comments
I don't think we can fix only our controller, middlewares are global to the application, right? Maybe we could just change all the PUTs to be POSTs. We don't really pass in data, I don't think it even fits the semantics of HTTP. |
true, i was thinking if there's a way to check for existing middleware within the app, the library could fast-fail.
That works too :) |
Would you be interested in contributing these changes? |
This issue has been marked as stale because it has not been commented on in two months. |
We should stop using PUTs and switch to POSTs. |
This issue has been marked as stale because it has not been commented on in two months. |
We should still change PUTs to POSTs 😅 |
Rack::MethodOverride
PUT
methods to POST
methods for better compat with API mode apps
Similar to #926, Rails API mode doesn't include the middleware that converts POST to PUT calls leading to
Routing Error
s.Possible solutions:
References https://github.com/Shopify/sidekick-server/issues/728
The text was updated successfully, but these errors were encountered: