escape_once filter is broken

[fw42]

The escape_once filter is passing tests, but is broken in templates.

>> Liquid::Template.parse('{{ "<strong>" | escape_once }}').render
=> "<strong>"

I assume that this is because the filters are set up in a different way in the tests than they are in strainer (and then in the real-thing, "ActionView::Helpers::TagHelper" raises a NameError). The whole NameError thing is super ugly. I would rather not define the filter at all if it's not available rather than returning the unescaped input.

@gauravmc, wanna take a look?

[fw42]

I don't think this ever worked in the first place o_O

[parkr]

@fw42 What kind of escape, URI or CGI?

[fw42]

See the code. It's using ActionView::Helpers::TagHelper.escape_once under the hood.

[nickpearson]

In case it helps, I thought I'd point out that there's some more discussion on this in #110.

[fw42]

Yeah the thing with the current implementation is that even IF the dependencies are loaded, it doesn't work.

[fw42]

Fixed in #287

[aprescott]

Are there plans to include this in a 2.x release?

[fw42]

@aprescott: Not really. The 2.x branches are not being worked on anymore.

[aprescott]

@fw42 in that case is the 3.x branch going to see a release any time soon? It'd be great to have this fix included.

[fw42]

@aprescott: We don't have a date set or anything. We are working on some refactorings (mostly for performance improvements and just general code quality) that we would like to see included.

[aprescott]

@fw42 👍 thanks, just curious, it'd be great to get this fix available. :)