Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Helm-style templating #44

Closed
KnVerey opened this issue Feb 27, 2017 · 6 comments
Closed

Support Helm-style templating #44

KnVerey opened this issue Feb 27, 2017 · 6 comments
Labels
🆕 feature Makes something new possible

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Feb 27, 2017

  • {env}.yaml with most values app maintainers will change parameterized
  • partials
  • probably not ERB (cloudplatform team did prototypes of this in both ERB and Golang)
@KnVerey KnVerey added the 🆕 feature Makes something new possible label Feb 27, 2017
@KnVerey
Copy link
Contributor Author

KnVerey commented Mar 16, 2017

A few notes:

cc @xldenis

@errordeveloper
Copy link

Have you seen my kubegen project? Lately, I've been playing around with some ideas around a macro syntax that would be native to YAML/JSON (somewhat alike CloudFormation), happy to chat more. I feel like plain text templating engines make the whole problem much more complex at times, and don't really guarantee valid output.

@KnVerey
Copy link
Contributor Author

KnVerey commented Aug 11, 2017

Hi @errordeveloper! I did check out your project at some point and it looks pretty cool. 😄 I've also got my eye on the ksonnet project's solution to this problem. Shopify is still using regular yamls for the time being, but we're actively exploring other options. As far as kubernetes-deploy is concerned, I'm currently thinking we'll either expect users to generate regular k8s defs with the tool of their choice before invoking it or at most add some sort of preprocessing plug-ins hooks. Making it super opinionated about a proprietary template format seems like the wrong way to go.

@skaes
Copy link
Contributor

skaes commented Nov 12, 2017

The main pain point for us are cronjobs. One of our teams has 20 of them. Just writing them down is an ordeal. Keeping them consistent after changes, for example in env variables, is a nightmare. I would love to have partials to solve this problem.

@skaes
Copy link
Contributor

skaes commented Nov 12, 2017

I have submitted a PR for a rather simple partials implementation which would nonetheless fulfill our needs. See #207

@KnVerey
Copy link
Contributor Author

KnVerey commented Dec 19, 2017

After giving this further thought, this is what I think we should do:

This gem's purpose is to be a deploy tool, not a templating engine. Basic ERB rendering is great for convenience, and we should keep it available in some form. However, there are many better community tools available for k8s templating, and our focus should be on cross-compatibility with those.

@ghost ghost modified the milestone: Sprint 0 Jul 5, 2018
@KnVerey KnVerey closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 feature Makes something new possible
Projects
None yet
Development

No branches or pull requests

3 participants