Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

safe-compare shouldn't be used in koa-shopify-auth #2

Closed
hgezim opened this issue May 9, 2020 · 2 comments · Fixed by #26
Closed

safe-compare shouldn't be used in koa-shopify-auth #2

hgezim opened this issue May 9, 2020 · 2 comments · Fixed by #26

Comments

@hgezim
Copy link

hgezim commented May 9, 2020

Node has a built-in method for it: https://nodejs.org/api/crypto.html#crypto_crypto_timingsafeequal_a_b
@hgezim hgezim changed the title safe-compare shouldn't be used safe-compare shouldn't be used in koa-shopify-auth May 9, 2020
@marutypes
Copy link

Thanks for the issue. This totally makes sense to do. If you would like to try it feel free to open a PR, otherwise it isn't super high impact so it might take a while to be addressed.

@amorriscode
Copy link
Contributor

Hey! 👋

I had some time this morning so I made an attempt at this one.

@atesgoral atesgoral transferred this issue from Shopify/quilt Sep 8, 2020
@amorriscode amorriscode mentioned this issue Oct 1, 2020
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

➖ Remove the need for external safe compare amorriscode/koa-shopify-auth
3 participants
@hgezim @marutypes @amorriscode