-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise lints are annoying #219
Comments
The issue with this is that promises swallow errors. In fact this can even swallow errors that don't have anything to do with the promises' asynchronous code. A workaround is manually adding a |
@TheMallen rethrowing in a catch won't cause them to be notified either though, right? It'll just get swallowed again |
I guess in the case where we have bugsnag we can do |
Yeah, the catch one is annoying but prevents a bad and kind of unexpected behaviour of promises, so I think we should leave it and have some sort of catch-all promise handling that people can use easily. I wouldn't really care if we ditch the always-return rule, I've also had cases where I kind of uselessly returned a value to satisfy the rule. |
|
I keep running into these two lint errors and not knowing what to do
In the first case I often don't care about the error state and just want it to fail and bugsnag notify when that happens.
In the second case I would be doing something with the result value of a promise, but don't want to chain the promise. Why would I need to return something in that case?
@lemonmade
The text was updated successfully, but these errors were encountered: