Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cart route so it works with no-js #2665

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Fix cart route so it works with no-js #2665

merged 3 commits into from
Dec 10, 2024

Conversation

wizardlyhel
Copy link
Contributor

WHY are these changes introduced?

Cart route doesn't render the cart when JavaScript is disabled. This change fixes the cart route so that it works with no-js.

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Dec 10, 2024

Oxygen deployed a preview of your hl-fix-cart-route branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment December 10, 202410:28 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment December 10, 202410:28 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment December 10, 202410:28 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment December 10, 202410:28 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment December 10, 202410:28 PM

Learn more about Hydrogen's GitHub integration.

@wizardlyhel wizardlyhel merged commit 105b31d into main Dec 10, 2024
11 checks passed
@wizardlyhel wizardlyhel deleted the hl-fix-cart-route branch December 10, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants