Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli plugin deps #2306

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Fix cli plugin deps #2306

merged 7 commits into from
Jul 8, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jul 8, 2024

The cli plugin in this repo is bundled in @shopify/cli already so we don't need to install it locally anymore.

This PR adds a missing changelog to inform users about removing the @shopify/cli-hydrogen dependency from their projects.
Aside from that, it updates cli-kit and fixes a couple of minor issues.

@frandiox frandiox requested a review from a team July 8, 2024 08:06
Copy link
Contributor

shopify bot commented Jul 8, 2024

Oxygen deployed a preview of your fd-fix-cli-plugin-deps branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 9:19 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 9:19 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 9:19 AM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 9:19 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 9:19 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 8, 2024 9:19 AM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox merged commit 18e76ba into main Jul 8, 2024
13 checks passed
@frandiox frandiox deleted the fd-fix-cli-plugin-deps branch July 8, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant