Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Codegen config resolution #2293

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jul 4, 2024

When the project directory contains ., the GraphQL config dependencies try to load it as a file with unknown extension, resulting in an unhandled exception.

image

This issue was also reported here: https://community.shopify.com/c/shopify-apps/how-can-i-fix-the-missing-loader-for-extension-error-in-hydrogen/td-p/2368900

@frandiox frandiox requested review from wizardlyhel and a team July 4, 2024 01:10
Copy link
Contributor

shopify bot commented Jul 4, 2024

Oxygen deployed a preview of your fd-fix-codegen-config-resolution branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 1:10 AM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 1:10 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 1:10 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 1:10 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 1:10 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 1:10 AM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox merged commit 426bb39 into main Jul 5, 2024
13 checks passed
@frandiox frandiox deleted the fd-fix-codegen-config-resolution branch July 5, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants