Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remix to v2.10.0 #2290

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Update remix to v2.10.0 #2290

merged 1 commit into from
Jul 3, 2024

Conversation

michenly
Copy link
Contributor

@michenly michenly commented Jul 3, 2024

Update Remix to 2.10.0 which included fixes to infinite loading error. With this we can re-introduce the usage of Layout Export safety.

Other notable changes is the introduction of future.unstable_fogOfWar flag, but we wont be using it in base Hydrogen project
2.10.0 https://github.com/remix-run/remix/blob/main/CHANGELOG.md#v2100
2.10.1 https://github.com/remix-run/remix/blob/main/CHANGELOG.md#v2101

@michenly michenly self-assigned this Jul 3, 2024
@michenly michenly requested a review from a team July 3, 2024 15:59
@michenly michenly force-pushed the mc-remix-upgrade branch 2 times, most recently from d3bec74 to b5becd6 Compare July 3, 2024 16:18
Copy link
Contributor

shopify bot commented Jul 3, 2024

Oxygen deployed a preview of your mc-remix-upgrade branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:23 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:23 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:23 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:23 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:23 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 3, 2024 9:23 PM

Learn more about Hydrogen's GitHub integration.

@michenly michenly force-pushed the mc-remix-upgrade branch from b5becd6 to c172f61 Compare July 3, 2024 20:54
@wizardlyhel
Copy link
Contributor

wizardlyhel commented Jul 3, 2024

why not bump to 2.10.1?

Also see mix of 2.10.0 and 2.10.1 in the package-lock.json. They all should be either 2.10.0 or 2.10.1

@michenly
Copy link
Contributor Author

michenly commented Jul 3, 2024

why not bump to 2.10.1?
I kinda figure the ^ will included it 😆

but I will resolved the dup for sure. Good catch!

@michenly michenly force-pushed the mc-remix-upgrade branch from c172f61 to 3bcfc67 Compare July 3, 2024 21:21
@michenly michenly force-pushed the mc-remix-upgrade branch from 3bcfc67 to 9b89ceb Compare July 3, 2024 21:21
@michenly
Copy link
Contributor Author

michenly commented Jul 3, 2024

Also see mix of 2.10.0 and 2.10.1 in the package-lock.json

@wizardlyhel I am actually not seeing the mix, but I updated all to 2.10.1 to avoid further confusion now

@michenly michenly merged commit 58001b8 into main Jul 3, 2024
13 checks passed
@michenly michenly deleted the mc-remix-upgrade branch July 3, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants