Fix cart.get() returning empty object for invalid ids
#2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
wizardlyhel
reviewed
Jun 18, 2024
| cartId, | ||
| ...cartInput, | ||
| }, | ||
| storefront.query<{cart: Cart | null}>(CART_QUERY(cartFragment), { |
There was a problem hiding this comment.
This doesn't need to specify the errors: StorefrontApiErrors type?
There was a problem hiding this comment.
That type is added internally in storefront.query as a union to whatever you pass here, so we don't need to specify it manually.
wizardlyhel
approved these changes
Jun 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2242
@wizardlyhel would this be the right fix? If we change
formatAPIResultit would affect many other methods in the cart, and I thinkcart.getis the only nullable one, right?