Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing custom data from provider to page view events #2224

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Fix missing custom data from provider to page view events #2224

merged 9 commits into from
Jun 12, 2024

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Jun 7, 2024 •
edited
Loading

WHY are these changes introduced?

Fix: #2225

  • The customData set at <Analytics.Provider> isn't being passed to the analytics view events
  • Fix infinite loop when a shop is linked but checkout domain is not supplied

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@shopify Shopify
Copy link
Contributor

shopify bot commented Jun 7, 2024 •
edited
Loading

Oxygen deployed a preview of your hl-fix-custom-data-analytics branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 3:19 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 3:19 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 3:19 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 3:19 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 3:19 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 3:19 PM

Learn more about Hydrogen's GitHub integration.

@michenly michenly changed the base branch from main to 2024-04 June 11, 2024 23:47
@wizardlyhel wizardlyhel changed the base branch from 2024-04 to main June 11, 2024 23:49
frandiox
frandiox approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Make sure to commit the package-lock.json after npm i, since you've removed a dependency.

packages/hydrogen/src/analytics-manager/AnalyticsProvider.tsx Outdated Show resolved Hide resolved
packages/hydrogen/src/analytics-manager/AnalyticsProvider.tsx Show resolved Hide resolved
@wizardlyhel wizardlyhel mentioned this pull request Jun 12, 2024
Merged
5 tasks
@wizardlyhel wizardlyhel merged commit e96b332 into main Jun 12, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-fix-custom-data-analytics branch June 12, 2024 17:07
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jun 12, 2024
Merged
@danhemerlein danhemerlein mentioned this pull request Aug 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

customData from the Analytics.Provider is undefined in the useAnalytics.subscribe() functions
2 participants
@wizardlyhel @frandiox