Refactor the product detail page and the cart #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
blittle
force-pushed
the
bl-components-refactor
branch
from
c016743 to
f6df8a9
Compare
This comment has been minimized.
This comment has been minimized.
blittle
force-pushed
the
bl-components-refactor
branch
from
6f40686 to
d821a68
Compare
| @@ -8,7 +8,7 @@ import type { | |||
| import {Aside} from '~/components/Aside'; | |||
| import {Footer} from '~/components/Footer'; | |||
| import {Header, HeaderMenu} from '~/components/Header'; | |||
| import {CartMain} from '~/components/Cart'; | |||
| import {CartMain} from '~/components/CartMain'; | |||
There was a problem hiding this comment.
I don't love the name CartMain — but not sure what else it should be
benjaminsehl
approved these changes
Jun 18, 2024
Merged
frandiox
reviewed
Jun 21, 2024
| @@ -309,6 +309,7 @@ export function PredictiveSearchForm({ | |||
| {...props} | |||
| className={className} | |||
| onSubmit={(event) => { | |||
| debugger; | |||
There was a problem hiding this comment.
@blittle We probably don't want this 😅
| @@ -93,7 +93,7 @@ export default function Cart() { | |||
| errorElement={<div>An error occurred</div>} | |||
| > | |||
| {(cart) => { | |||
| return <CartMain layout="page" cart={cart} />; | |||
| return <CartMain layout="page" cart={cart!} />; | |||
There was a problem hiding this comment.
Maybe we should make CartMain get cart: Cart | null instead of adding ! everywhere?
There was a problem hiding this comment.
but what if Bret just really wants to put a lot of emphasis on cart? ;)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to refactor the starter template, moving things around while maintaining existing functionality. The hope is to make the code more self documenting and easy to understand.
Things to include