Throw build errors when lockfile is not valid on CI #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frandiox
force-pushed
the
fd-lockfile-error
branch
from
8294fdf
to
091be60
Compare
wizardlyhel
approved these changes
Sep 25, 2023
frandiox
force-pushed
the
fd-lockfile-error
branch
from
8b3d6a3
to
79e7f44
Compare
This reverts commit 79e7f44.
|
Let's wait to merge this PR until https://github.com/Shopify/oxygen-platform/issues/1365 is fixed. Currently, we can't access env variables within the Oxygen action so we can't detect if we're running on CI properly. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/Shopify/custom-storefronts/issues/277
This could be a problem for monorepos where the lockfile can't be found in the project -- I think Yarn and pnpm can output lockfile in every workspace project but NPM can't afaik.
Is the
--no-lockfile-checkflag enough for this? 🤔🎩