Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action needed] support RN 0.77 #1466

Open
1 of 2 tasks
vonovak opened this issue Jan 7, 2025 · 0 comments
Open
1 of 2 tasks

[action needed] support RN 0.77 #1466

vonovak opened this issue Jan 7, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@vonovak
Copy link

vonovak commented Jan 7, 2025

Hello,
because of facebook/react-native#46809 there are changes that need to be done, similar to AppAndFlow/react-native-safe-area-context#566. This is a heads up for the maintainers.

Current behavior

build with old architecture on RN 0.77 fails with

e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:16:74 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.AutoLayoutViewManagerInterface<com.shopify.reactnative.flash_list.AutoLayoutView!>)!'.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/AutoLayoutViewManager.kt:17:39 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.AutoLayoutViewManager', but 'U!' was expected.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:13:76 Type argument is not within its bounds: should be subtype of 'it(BaseViewManagerInterface & com.facebook.react.viewmanagers.CellContainerManagerInterface<com.shopify.reactnative.flash_list.CellContainerImpl!>)!'.
e: file:@shopify/flash-list/android/src/main/kotlin/com/shopify/reactnative/flash_list/CellContainerManager.kt:14:40 Argument type mismatch: actual type is 'com.shopify.reactnative.flash_list.CellContainerManager', but 'U!' was expected.

Expected behavior

build should pass

To Reproduce

upgrade to latest RN 0.77 and build an app with flash list dep, with old arch

Platform:

  • iOS
  • Android

Environment

x.y.z

@vonovak vonovak added the bug Something isn't working label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant