Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0-beta.2 #63

Merged
merged 34 commits into from
Oct 10, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
542a3b8
Add nvmrc file with node v8.6.0
tsov Oct 6, 2017
2d3ab5e
Restructure of Draggable
tsov Oct 6, 2017
370227d
Restructure of Droppable
tsov Oct 6, 2017
e62a64e
Restructure of Swappable
tsov Oct 6, 2017
5946237
Restructure of Sortable
tsov Oct 6, 2017
ca8cd69
Restructure of Sensors
tsov Oct 6, 2017
85b231b
Restructure tests
tsov Oct 6, 2017
ba996cd
Restructure utils
tsov Oct 6, 2017
277f7ab
Export AbstractEvent as BaseEvent
tsov Oct 6, 2017
0e5f036
Restructure draggable core plugins
tsov Oct 6, 2017
cdebacb
Restructure Plugins
tsov Oct 6, 2017
e8732f9
Restructure events
tsov Oct 6, 2017
da60cbd
Move utils into shared folder
tsov Oct 6, 2017
7777823
Move sensors to Draggable
tsov Oct 6, 2017
26a3029
Fix draggable tests
tsov Oct 6, 2017
be8cb9a
Update node version for circleci
tsov Oct 6, 2017
f376c5a
Rename sortable
tsov Oct 6, 2017
a8d9bd6
Rename utils folder
tsov Oct 6, 2017
fa8caca
Clone callbacks array before event triggering
tsov Oct 7, 2017
8eae84c
Always add mirror and accessibility plugin for now
tsov Oct 7, 2017
aca0fbe
Don't hide source element if drag action is too fast
tsov Oct 7, 2017
a7fc70f
Resolving some more issues around movable source
tsov Oct 8, 2017
07e98f3
Rename source to originalSource
tsov Oct 9, 2017
2433eea
Mouse sensor prevents contextmenu while dragging
tsov Oct 9, 2017
08ab17b
Temporary solution for automatic user select none on drag
tsov Oct 9, 2017
b10ff77
Improvements to closest function
tsov Oct 9, 2017
74de416
Use utils closest function instead of native browser closest
tsov Oct 9, 2017
b503d29
Add defaults to Droppable, so no error is thrown if the user doesn’t …
Oct 2, 2017
37321a8
Fix up linting errors for droppable
tsov Oct 9, 2017
e45f134
Prevent native drag events for mouse sensor
tsov Oct 10, 2017
48a1828
Prevent drag start on mouse click with ctrl on mac in mouse sensor
tsov Oct 10, 2017
b2ff5da
Disable force touch sensor by default
tsov Oct 10, 2017
af86f49
Add changelog
tsov Oct 10, 2017
9c63ded
v1.0.0-beta.2
tsov Oct 10, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 2
jobs:
build:
docker:
- image: circleci/node:8.2.1
- image: circleci/node:8.6.0

working_directory: ~/repo

Expand Down
12 changes: 11 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,15 @@ module.exports = {
rules: {
'import/no-unresolved': 'off',
'import/no-extraneous-dependencies': 'off',
}
},
globals: {
jest: false,
afterAll: false,
afterEach: false,
beforeAll: false,
beforeEach: false,
describe: false,
test: false,
expect: false,
},
};
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v8.6.0
28 changes: 28 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Changelog

## v1.0.0-beta.2 - 2017-10-10

### Added

- Code of Conduct
- Contribution guidelines
- Documentation on `appendTo` option for `Draggable`
- Added concept of `originalSource`
- Fix for text selection issue
- Fix for native drag events firing for the `MouseSensor`
- Fix for missing `classes` option

### Changes

- README updates
- Touch improvements
- ForceTouchSensor is not included by default anymore
- Folder/File restructure
- Exports `AbstractEvent` as `BaseEvent`
- Update node version from `8.2.1` to `8.6.0`
- Clones event callbacks before triggering (to prevent mutation during iterations)
- Improvements to `closest` utils helper

## v1.0.0-beta - 2017-09-27

Initial release
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ using mouse events, otherwise mirror will be `null` in events. Default: `false`

**`plugins {Array[Plugin]}`**
Plugins add behaviour to Draggable by hooking into its life cycle, e.g. one of the default
plugins controls the mirror movement. Default: `[Mirror, Accessibility]`
plugins controls the mirror movement. Default: `[]`

**`appendTo {String|HTMLElement|Function}`**
Draggable allows you to specify where the mirror should be appended to. You can specify a css
Expand Down
6 changes: 3 additions & 3 deletions config.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"testMatch": ["<rootDir>/test/src/**/*.js"],
"setupFiles": ["<rootDir>/test/setup.js"],
"testMatch": ["<rootDir>/src/**/*.test.js"],
"setupFiles": ["<rootDir>/scripts/test/setup.js"],
"transform": {".*": "<rootDir>/node_modules/babel-jest"},
"moduleFileExtensions": ["js"],
"collectCoverageFrom": [
"src/**/*.js"
],
"moduleDirectories": ["node_modules", "src", "test"]
"moduleDirectories": ["node_modules", "src", "scripts/test"]
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@shopify/draggable",
"version": "1.0.0-beta",
"version": "1.0.0-beta.2",
"private": false,
"license": "MIT",
"description": "The JavaScript Drag & Drop library your grandparents warned you about.",
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import AbstractEvent from './abstract-event';
import AbstractEvent from 'shared/AbstractEvent';

export class DragEvent extends AbstractEvent {
get source() {
return this.data.source;
}

get movableSource() {
return this.data.movableSource;
get originalSource() {
return this.data.originalSource;
}

get mirror() {
Expand Down
1 change: 1 addition & 0 deletions src/Draggable/DragEvent/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
## Drag event
10 changes: 10 additions & 0 deletions src/Draggable/DragEvent/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
export {
DragStartEvent,
DragMoveEvent,
DragOutContainerEvent,
DragOutEvent,
DragOverContainerEvent,
DragOverEvent,
DragStopEvent,
DragPressureEvent,
} from './DragEvent';
Loading