From e75d0b8e4ea381047afca2880c54e34f8b864123 Mon Sep 17 00:00:00 2001 From: Max Hoffmann Date: Sat, 24 Mar 2018 19:33:40 -0400 Subject: [PATCH 1/2] Touch sensor scrolling bug --- src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js b/src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js index 6dba7ed12..006e7941a 100644 --- a/src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js +++ b/src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js @@ -94,7 +94,7 @@ describe('TouchSensor', () => { expect(dragFlow).toHaveTriggeredSensorEvent('drag:stop'); }); - it('prevents `drag:start` when holding finger on none draggable element', () => { + it('prevents `drag:start` when trying to drag a none draggable element', () => { function dragFlow() { touchStart(document.body); waitForDragDelay(); From eb4d73ef80fc23a521ad3d7c52c9f84f18669c09 Mon Sep 17 00:00:00 2001 From: beefchimi Date: Fri, 30 Mar 2018 19:03:00 -0400 Subject: [PATCH 2/2] remove some unnecessary styles from StackedList component --- .../src/components/StackedList/variants.scss | 26 ------------------- .../Sortable/SimpleList/SimpleList.html | 22 ++++++++++------ .../Sortable/SimpleList/SimpleList.scss | 16 ------------ 3 files changed, 14 insertions(+), 50 deletions(-) diff --git a/examples/src/components/StackedList/variants.scss b/examples/src/components/StackedList/variants.scss index aff079100..b646b144c 100644 --- a/examples/src/components/StackedList/variants.scss +++ b/examples/src/components/StackedList/variants.scss @@ -45,32 +45,6 @@ opacity: 0.1; } } - - // Size variants - - .StackedListWrapper--sizeMedium & { - @include stacked-list-scroll-height( - stacked-list-item(medium), 3 - ); - - @media screen and (min-width: get-breakpoint(desktop)) { - @include stacked-list-scroll-height( - stacked-list-item(medium, desktop), 3 - ); - } - } - - .StackedListWrapper--sizeLarge & { - @include stacked-list-scroll-height( - stacked-list-item(large), 3 - ); - - @media screen and (min-width: get-breakpoint(desktop)) { - @include stacked-list-scroll-height( - stacked-list-item(large, desktop), 3 - ); - } - } } .StackedList--hasScroll { diff --git a/examples/src/content/Sortable/SimpleList/SimpleList.html b/examples/src/content/Sortable/SimpleList/SimpleList.html index dfea9610c..2bf55b6e1 100644 --- a/examples/src/content/Sortable/SimpleList/SimpleList.html +++ b/examples/src/content/Sortable/SimpleList/SimpleList.html @@ -2,18 +2,24 @@ {% macro render(id) %}
-
+

Simple list

-
    - {{ StackedListItem.render('item one', {index: 1, draggable: true}) }} - {{ StackedListItem.render('item two', {index: 2, draggable: true}) }} - {{ StackedListItem.render('item three', {index: 3, draggable: true}) }} - {{ StackedListItem.render('item four', {index: 4, draggable: true}) }} - {{ StackedListItem.render('item five', {index: 5}) }} - {{ StackedListItem.render('item six', {index: 6, draggable: true}) }} +
      + {{ StackedListItem.render('item one', {index: 1, draggable: true}) }} + {{ StackedListItem.render('item two', {index: 2, draggable: true}) }} + {{ StackedListItem.render('item three', {index: 3, draggable: true}) }} + {{ StackedListItem.render('item four', {index: 4, draggable: true}) }} + {{ StackedListItem.render('item five', {index: 5}) }} + {{ StackedListItem.render('item six', {index: 6, draggable: true}) }} + {{ StackedListItem.render('item seven', {index: 7, draggable: true}) }} + {{ StackedListItem.render('item eight', {index: 8}) }} + {{ StackedListItem.render('item nine', {index: 9}) }} + {{ StackedListItem.render('item ten', {index: 10, draggable: true}) }} + {{ StackedListItem.render('item eleven', {index: 11}) }} + {{ StackedListItem.render('item twelve', {index: 12, draggable: true}) }}
diff --git a/examples/src/content/Sortable/SimpleList/SimpleList.scss b/examples/src/content/Sortable/SimpleList/SimpleList.scss index 18d48ba9c..0fc190e9c 100644 --- a/examples/src/content/Sortable/SimpleList/SimpleList.scss +++ b/examples/src/content/Sortable/SimpleList/SimpleList.scss @@ -8,20 +8,4 @@ .SimpleList { @include centered-width(columns(5)); - - .StackedListWrapper { - .StackedListHeader { - @media screen and (min-width: get-breakpoint(desktop)) { - display: flex; - align-items: center; - height: stacked-list-item(medium); - } - } - - .StackedListContent { - @media screen and (min-width: get-breakpoint(desktop)) { - height: stacked-list-item(medium); - } - } - } }