Add card outline setting #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tauthomas01
reviewed
Jul 22, 2021
…outline-setting # Conflicts: # sections/main-search.liquid
tyleralsbury
previously approved these changes
Jul 27, 2021
tauthomas01
previously approved these changes
Aug 2, 2021
…outline-setting # Conflicts: # sections/main-collection-product-grid.liquid
tyleralsbury
approved these changes
Aug 3, 2021
tauthomas01
approved these changes
Aug 3, 2021
maplerock
added a commit
to fellowsmedia/nsra_shopify_2021
that referenced
this pull request
Aug 12, 2021
* main: (23 commits) Cart content update (Shopify#370) Footer spacing and alignment adjustments (Shopify#369) Product Template UI polish updates (Shopify#219) footer ui updates (Shopify#318) Fix cart improvements empty state (Shopify#319) [Announcement] Adjust block id for displaying dynamic names (Shopify#327) Update translations: buyer (Shopify#329) Revert editor setting changes (Shopify#328) Update translations (Shopify#294) Fix collection filtering UX (Shopify#268) Added page width setting and fixed image quality (Shopify#292) Add top border on cart notification when "show separator line" setting is deactivated (Shopify#306) movebadge code into base.css (Shopify#313) Collage UI bug fixes (Shopify#308) Customer account UI polish (Shopify#177) Added custom liquid block to product page (Shopify#269) Fix disclosure icon (Shopify#310) Fix facet price filter label spacing (Shopify#300) Fix duplicate search icon when header logo is set to "Top center" (Shopify#252) Add card outline setting (Shopify#239) ...
phapsidesGT
pushed a commit
to Gravytrain-UK/gt-shopify-dawn-theme
that referenced
this pull request
Sep 3, 2024
* Add setting to product-grid to toggle product card outline * Update all instances of product-card snippet * Simplify liquid logic for showing outline * Fix typo * Update 11 translation files * Update 7 translation files * Update 2 translation files Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes introduced?
Fixes #189
What approach did you take?
Add
Show image outlinesetting to sections:main-collection-product-gridfeatured-collectionmain-searchproduct-recommendationsAdd logic in
product-cardsnippet to conditionally show image outlineUpdate CSS
Updates locales
Other considerations
Demo links
Checklist