Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the text color value removes mostly all CSS #52

Closed
nicklepine opened this issue Jun 25, 2021 · 0 comments · Fixed by #83
Closed

Removing the text color value removes mostly all CSS #52

nicklepine opened this issue Jun 25, 2021 · 0 comments · Fixed by #83
Assignees
@KaichenWang
Labels
Category: Bug Something isn't working Severity: 1 Urgent Severity

Comments

@nicklepine
Copy link

nicklepine commented Jun 25, 2021 •
edited by bertiful
Loading

Issue:
Removing the text color removes mostly all color CSS from the page (tested on mobile)

Steps to reproduce
Open mobile view in the browser
Open theme settings
Remove color content for text
Watch the page wipe itself of colors
https://screenshot.click/26-29-vbw7f-zf0gu.mp4

Potential ways to fix
Can we make colors required fields? Or could we set a default fallback color value if those get erased?

image
@nicklepine nicklepine added Category: Bug Something isn't working Severity: 1 Urgent Severity labels Jun 25, 2021
@KaichenWang KaichenWang self-assigned this Jun 30, 2021
@KaichenWang KaichenWang mentioned this issue Jun 30, 2021
Merged
5 tasks
KaichenWang pushed a commit that referenced this issue Jan 10, 2023
@ludoboludo
Merge pull request #52 from Shopify/version-bump-v7.0.1
c6c3afa 
Dawn - release note and version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaichenWang KaichenWang

Labels
Category: Bug Something isn't working Severity: 1 Urgent Severity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update color variables for rgb. Remove unused color variables Shopify/dawn
2 participants
@KaichenWang @nicklepine