Adjust CSS for new Portable Wallet #3629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
There has been changes in a way the dynamic pay buttons (Pay now, pay with PayPal etc) are rendered. Currently, we have our own selectors to style those buttons, but since the whole HTML structure has been changed we need to make adjustments.
So far, everything works fine just because there is backward compatibility. But there are plans to remove it and then the current styling won't work.
Here is a doc that describes CSS properties we need to use to properly style shopify pay buttons.
There are some know issues:
Why are these changes introduced?
Fixes #3613.
What approach did you take?
I removed old selectors we used to apply styles (shadow and border radius) to shopify pay buttons.
I added new selectors with some properties we previously used and linked them to our variables.
You can noticed that I didn't add all available properties to selectors, we still get them with default values mentioned in this doc.
Other considerations
It's possible I missed something and removed not all references to previous selectors, but I think I removed the most obvious ones and even if something was left it shouldn't impact the style of the buttons.
Visual impact on existing themes
There shouldn't be any visual impact.
Testing steps/scenarios
Demo links