Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic checkout button appears for products with a selling plans, docs state it should not #3273

Closed
willbroderick opened this issue Feb 12, 2024 · 1 comment

Comments

@willbroderick
Copy link

Describe the current behavior

When you visit the product page for a product with a selling plan, the dynamic checkout button appears.

Describe the expected behavior

That it does not appear. The documentation states that it should not.
https://shopify.dev/docs/themes/pricing-payments/purchase-options/subscription-ux-guidelines#main-call-to-action

Shopify doesn't display the dynamic checkout button on products that include selling plans. Ensure that the theme accounts for this, and that the primary call-to-action style is used for the form submission.

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 13

Possible solution

Either update the documentation, or hide the button for selling plan products. Notifying Theme Partners about the outcome will be useful, as many premium themes follow the documentation on this.

@willbroderick
Copy link
Author

willbroderick commented Oct 31, 2024

Closing issue.

Documentation was updated to remove any reference to the button being hidden for subscriptions, seemingly without informing any theme partners or devs.

So it may be supported, or not, it's impossible to find out without trying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant