Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve loading of rte styles #2209

Closed
kmeleta opened this issue Jan 11, 2023 · 0 comments · Fixed by #2326
Closed

Improve loading of rte styles #2209

kmeleta opened this issue Jan 11, 2023 · 0 comments · Fixed by #2326
Labels
Category: Enhancement New feature or request Category: Tech Debt Opportunities to refactor or improve the code and/or development workflow

Comments

@kmeleta
Copy link
Contributor

kmeleta commented Jan 11, 2023

Because the rte styles are used in many areas now, we might consider loading component-rte.css once in theme.liquid and removing the reference from individual sections. However, we might also consider just moving those styles into base.css instead to be more performant. Mentioned here
@kmeleta kmeleta added Category: Enhancement New feature or request Category: Tech Debt Opportunities to refactor or improve the code and/or development workflow labels Jan 11, 2023
@kmeleta kmeleta mentioned this issue Jan 11, 2023
Merged
8 tasks
This was referenced Feb 23, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Enhancement New feature or request Category: Tech Debt Opportunities to refactor or improve the code and/or development workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Rich text] Change rich text section heading type Shopify/dawn
1 participant
@kmeleta