Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to safe and more efficient JSON library #35

Closed
plokhotnyuk opened this issue Dec 12, 2019 · 2 comments
Closed

Migration to safe and more efficient JSON library #35

plokhotnyuk opened this issue Dec 12, 2019 · 2 comments

Comments

@plokhotnyuk
Copy link
Contributor

plokhotnyuk commented Dec 12, 2019

Json4s is vulnerable under DoS/DoW attacks which exploit O(n^2) complexity of insertion into Scala's hash maps in case of colliding hash codes or parsing of JSON numbers.

Would you consider migration to a much safer and more efficient library like jsoniter-scala?

@plokhotnyuk plokhotnyuk changed the title Migration to safe and more efficient library Migration to safe and more efficient JSON library Dec 12, 2019
@gertjana
Copy link
Member

Thanks for reporting this, of course, we would consider moving to a safer and more efficient library
but we would probably pick one, that is better supported in the open-source community.

@reinierl
Copy link
Contributor

reinierl commented Jan 7, 2020

As JSON4S indeed seems not very intensely maintained, we'd probably pick something else if we'd had to write this library today. For now it works though and these issues don't seem serious enough to warrant an overhaul to a different JSON library. So I'm closing this ticket for now.

Note also that OCPP is typically used between systems that trust each other. This kind of issue seems more urgent for people who host public web APIs to me.

@reinierl reinierl closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants