Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] has incorrect peer dependency react@>= 15 < 16.3 #184

Open
barrymichaeldoyle opened this issue Sep 18, 2018 · 2 comments

Comments

@barrymichaeldoyle
Copy link

Why doesn't this package work with React 16.4?

@perepelitca
Copy link
Contributor

Also found an issue with that dependency range.
UNSAFE_componentWillReceiveProps was introduced in 16.3 version, so if I use 16.2, that method won't be called and selectedItems won't be updated. I would say peer dependencies or UNSAFE_componentWillReceiveProps should be changed

@Sharlaan
Copy link
Owner

Sharlaan commented Jan 8, 2019

@barrymichaeldoyle it is exactly for this reason: deprecation of old lifecycle hooks.

In practice tough, i admit i would need some help on how to manage versions and old/new lifecycle hooks,since poeple seem to complain current solution ie :

  • a version range maxed at v16.3 non inluded,
  • change old lifecycle hooks into their UNSAFE_ version

I'm open to better ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants