-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IFramePanel implemenation #226
Conversation
HI @spdavid!
|
Codecov Report
@@ Coverage Diff @@
## dev #226 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 16 16
Lines 744 744
Branches 138 148 +10
=======================================
Hits 541 541
Misses 159 159
Partials 44 44 Continue to review full report at Codecov.
|
@AJIXuMuK All checks now passed. |
Thanks @spdavid, I did some code changes to the control for consistency, but also for retrieving the parent element by the className. Control has been merged and will be available in |
What's in this Pull Request?
New Implemenation of an IFramePanel control Similar to the IFrameDialog except renders an IFrame in a Fabric UI Panel. Did not open a discussion for this but I needed to build it anyway. Add it if everyone feels its a good idea.
Has a nice dynamic height if the height is not set. Tested in IE, Chrome, Edge.